God read my code and it made Him cry
“Update”
It was my dotfiles, ok?
You’re going to regret not adding the second sentence to the commit message some day.
Bold of you to assume there is a cohesive theme to dotfile commits. Usually it’s just been long enough that I don’t want to lose my latest tweaks
Removed double quotes, added single quotes
someone later on -m “removed single quotes, added double quotes”
More commits == More money!!!
Real talk: I have worked at a company where an exec briefly had the bright idea to rank developers on number of commits made.
You can imagine how that turned out.
He wasn’t an exec for very long.
lmaoo, I can’t believe someone actually did that and was serious about it.
I’m already imagining commits piling up with comments like:- “add a newline”
- “move function up”
- “rename variable
users
touser_list
” - “Revert previous commit”
- “no John, it’s
user_list
and that’s it, don’t you dare change it again”
He wasn’t an exec for very long.
Good riddance I guess
Oh, no, we can do better.
Every single line of every single PR is an individual commit. And never squash-commit.
Talk about atomic commits
Why do u prefer single quotes?
Not Shall330, but double quotes can imply variables in the string in some languages.
Which languages are these?
PHP for one. “$x” will interpret the variable $x. ‘$x’ does not.
Well there’s ya problem ur using php.
Also bash
And Perl.
I have no preference! It was to do with Spring/yaml config and some really strange conflict which required the use of single quotes. I’m still a total noob in the world of software dev, so I wouldn’t be able to explain why it worked 🤣
Initial commit
Initial commit #463
grats on formalising your (new) project
“fix for real this time”
Revert this later
Yikes
“Changed consent banner text to reflect from legal, even though they are wrong”
“circumvented GDPR despite calling out strong ethical objections, because legal & management are forcing me to”
haaaands
Lint issue
Refactoring for the EU region.
Reusing Terraform projects for the win.
Tests: Add a few test files.
I thought we lost you … Jia Tan!
Squash me later
My commit messages have gotten extremely lazy since I start squashing all my commits down to one. I just describe the PR on the first commit message and write nonsense in all the others.
I’ve been adding the commit shas + messages to the final description, if anyone wants to see my exploratory work.
I know that if you are on the local repository where the commits were originally created they’ll remain accessible through recovery methods but AFAIK orphaned commits aren’t synced to other machines.
That’s correct. This is for work, which uses GitHub. The dangling commits remain accessible via their sha through the web ui, so I can link them in the PR description. I don’t put them in the actual commit message.
I think these are garbage collected eventually, but no idea on cadence. It’s long, anyway.
Fix
git commit -m “if this doesn’t fix it I’m looking up availabilities at my nearest maccas”
“28496 - there, it’s fucking fixed you twat waffle.”
Ticketed bug bosses son found. Dude nagged his dad who nagged us until it got fixed. Boss doesn’t review code. And for the sake of a half dozen coworkers, I hope he never does.